Skip to content

feat(mol): add MOL type/function and PATTERN index#1797

Open
862103595 wants to merge 4 commits intomilvus-io:masterfrom
862103595:feat/mol-support
Open

feat(mol): add MOL type/function and PATTERN index#1797
862103595 wants to merge 4 commits intomilvus-io:masterfrom
862103595:feat/mol-support

Conversation

@862103595
Copy link
Copy Markdown

@862103595 862103595 commented Apr 7, 2026 •
edited
Loading

related:

  • add DataType.Mol
  • add FunctionType.MOL_FINGERPRINT
  • add PATTERN index enum (v1/v2)
  • support mol_smiles_data serialization and SMILES validation

@sre-ci-robot
Copy link
Copy Markdown

sre-ci-robot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 862103595
To complete the pull request process, please assign yhmo after the PR has been reviewed.
You can assign the PR to them by writing /assign @yhmo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Copy Markdown

sre-ci-robot commented Apr 7, 2026

Welcome @862103595! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉

@mergify mergify Bot added the needs-dco label Apr 7, 2026
@sre-ci-robot sre-ci-robot added size/M and removed size/S labels Apr 9, 2026
862103595 added 2 commits April 9, 2026 13:09
@862103595
feat(mol): add MOL data type, function, and PATTERN index
97c76cd 
Signed-off-by: xiejh <862103595@qq.com>
@862103595
fix(mol): complete MOL scalar readback support
4c84d4f 
Signed-off-by: xiejh <862103595@qq.com>
@liliu-z
Copy link
Copy Markdown
Member

liliu-z commented Apr 20, 2026

sdk-bulkwriter/src/main/java/io/milvus/bulkwriter/BulkWriter.java:1 The sdk-bulkwriter module is missing Mol type support entirely. verifyByDatatype in BulkWriter.java, schema construction in ParquetUtils.java, and the string serialization branch in ParquetFileWriter.java all need case Mol: branches added — without them, bulk import of Mol data will throw or silently fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@yhmo yhmo Awaiting requested review from yhmo

Assignees

No one assigned

Labels

ci-passed dco-passed size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@862103595 @sre-ci-robot @liliu-z @yhmo